e1000e: remove unnecessary range check in e1000e_phc_adjfreq
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 21 Jul 2022 21:29:56 +0000 (14:29 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 28 Jul 2022 17:55:56 +0000 (10:55 -0700)
The e1000e_phc_adjfreq function validates that the input delta is within
the maximum range. This is already handled by the core PTP code and this is
a duplicate and thus unnecessary check. It also complicates refactoring to
use the newer .adjfine implementation, where the input is no longer
specified in parts per billion. Remove the range validation check.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e1000e/ptp.c

index eb5c014..432e04c 100644 (file)
@@ -33,9 +33,6 @@ static int e1000e_phc_adjfreq(struct ptp_clock_info *ptp, s32 delta)
        u32 timinca, incvalue;
        s32 ret_val;
 
-       if ((delta > ptp->max_adj) || (delta <= -1000000000))
-               return -EINVAL;
-
        if (delta < 0) {
                neg_adj = true;
                delta = -delta;