Delete unreached code and fix coding rule

[Version] 0.2.214
[Profile] Common
[Issue Type] coding rule
[Dependency module] N/A
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-mobile_20161212-2]

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: I93c21708ccb970222a6648170c0495a3b565e9ab

diff --git a/packaging/libmm-wfd.spec b/packaging/libmm-wfd.spec
index edd96cb9f652a0b39b588392d943f079cdd2f8f6..8300d771955222fbf8b63d001ac29c838496f68c 100644 (file)
--- a/packaging/libmm-wfd.spec
+++ b/packaging/libmm-wfd.spec
@@ -1,6 +1,6 @@
 Name:       libmm-wfd
 Summary:    Multimedia Framework Wifi-Display Library
-Version:    0.2.213
+Version:    0.2.214
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0
@@ -22,13 +22,17 @@ BuildRequires: pkgconfig(libtbm)
 BuildRequires: pkgconfig(libtzplatform-config)
 BuildRequires: pkgconfig(capi-system-info)
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
+
 %description
+A Wfd library in Tizen native API
 
 %package devel
 Summary:    Multimedia Framework Wifi-Display Library (DEV)
 Group:      Development/Libraries
 Requires:   %{name} = %{version}-%{release}
+
 %description devel
+Development related files for a wfd library in Tizen native API
 
 %package factory
 Summary:    Multimedia Framework Wifi-Display Library (Factory)

diff --git a/src/mm_wfd_sink_priv.c b/src/mm_wfd_sink_priv.c
index 35a96c173fa74e1ad78830ae03bcfe3a9948a5ba..10918fbabe950ca3146c3a5b5f1d6b67b5a135ef 100644 (file)
--- a/src/mm_wfd_sink_priv.c
+++ b/src/mm_wfd_sink_priv.c
@@ -672,7 +672,7 @@ int __mm_wfd_sink_activate_video_stream(mm_wfd_sink_t *wfd_sink)
 
        if (gst_pad_is_linked(srcpad)) {
                wfd_sink_debug("%s is already linked",
-                                               GST_ELEMENT_NAME(GST_PAD_PARENT(sinkpad)), GST_PAD_NAME(sinkpad));
+                                               GST_ELEMENT_NAME(GST_PAD_PARENT(srcpad)), GST_PAD_NAME(srcpad));
                goto done;
        }
 
@@ -3031,15 +3031,11 @@ static int __mm_wfd_sink_create_pipeline(mm_wfd_sink_t *wfd_sink)
 CREATE_ERROR:
        wfd_sink_error("ERROR : releasing pipeline");
 
-       if (element_bucket)
+       if (element_bucket) {
                g_list_free(element_bucket);
-       element_bucket = NULL;
-
-       /* finished */
-       if (bus) {
-               gst_object_unref(GST_OBJECT(bus));
-               bus = NULL;
+               element_bucket = NULL;
        }
+
        /* release element which are not added to bin */
        for (i = 1; i < WFD_SINK_M_NUM; i++) {  /* NOTE : skip pipeline */
                if (mainbin != NULL && mainbin[i].gst) {
@@ -4028,11 +4024,10 @@ static int __mm_wfd_sink_prepare_videosink(mm_wfd_sink_t *wfd_sink, GstElement *
                                        }
                                        wfd_sink_debug("set video param : surface_id %d", wl_surface_id);
 
-                                       if(USE_EXTERNAL_WL_DISPLAY_HANDLE) {
+                                       if (USE_EXTERNAL_WL_DISPLAY_HANDLE) {
                                                gst_video_overlay_set_window_handle(GST_VIDEO_OVERLAY(video_sink),
                                                                                                                wl_surface_id);
-                                       }
-                                       else {
+                                       } else {
                                                gst_video_overlay_set_wl_window_wl_surface_id(GST_VIDEO_OVERLAY(video_sink),
                                                                                                                                wl_surface_id);
                                        }