firmware: Drop unused pages field from struct firmware
authorTakashi Iwai <tiwai@suse.de>
Wed, 15 Apr 2020 16:45:00 +0000 (18:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Apr 2020 07:59:39 +0000 (09:59 +0200)
The struct firmware contains a page table pointer that was used only
internally in the past.  Since the actual page tables are referred
from struct fw_priv and should be never from struct firmware, we can
drop this unused field gracefully.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20200415164500.28749-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/main.c
include/linux/firmware.h

index 76f7991..5296aac 100644 (file)
@@ -548,9 +548,6 @@ static void firmware_free_data(const struct firmware *fw)
 static void fw_set_page_data(struct fw_priv *fw_priv, struct firmware *fw)
 {
        fw->priv = fw_priv;
-#ifdef CONFIG_FW_LOADER_USER_HELPER
-       fw->pages = fw_priv->pages;
-#endif
        fw->size = fw_priv->size;
        fw->data = fw_priv->data;
 
index 4bbd0af..cb3e2c0 100644 (file)
@@ -12,7 +12,6 @@
 struct firmware {
        size_t size;
        const u8 *data;
-       struct page **pages;
 
        /* firmware loader private fields */
        void *priv;