child_process: fix assertion error in spawnSync

When ExitCallback was not called with an error such as ENOENT in
uv_spawn, the process handle still remains refed and needs to be closed.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>

diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
index 481d0eff09eada9cdba18d4125f75064fb3827d3..29de6862d5c1e8df08e865c1508521f8ab5c771d 100644 (file)
--- a/src/spawn_sync.cc
+++ b/src/spawn_sync.cc
@@ -511,6 +511,11 @@ void SyncProcessRunner::CloseHandlesAndDeleteLoop() {
   if (uv_loop_ != NULL) {
     CloseStdioPipes();
     CloseKillTimer();
+    // Close the process handle when ExitCallback was not called.
+    uv_handle_t* uv_process_handle =
+        reinterpret_cast<uv_handle_t*>(&uv_process_);
+    if (!uv_is_closing(uv_process_handle))
+      uv_close(uv_process_handle, NULL);
 
     // Give closing watchers a chance to finish closing and get their close
     // callbacks called.

diff --git a/test/simple/test-child-process-spawnsync.js b/test/simple/test-child-process-spawnsync.js
index f19200166a2726f7c137ab94a3d6bfc3772c2de9..e3304dc99c1e04db4d99bc4abf8eb66f6f38aa61 100644 (file)
--- a/test/simple/test-child-process-spawnsync.js
+++ b/test/simple/test-child-process-spawnsync.js
@@ -39,6 +39,10 @@ console.log('sleep started');
 var ret = spawnSync('sleep', ['1']);
 console.log('sleep exited');
 
+// Error test when command does not exist
+var ret_err = spawnSync('command_does_not_exist');
+assert.strictEqual(ret_err.error.code, 'ENOENT');
+
 process.on('exit', function() {
   assert.strictEqual(ret.status, 0);