firmware: dmi-sysfs: use default_groups in kobj_type
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jan 2022 18:17:19 +0000 (19:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Jan 2022 13:28:22 +0000 (14:28 +0100)
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field.  Move the firmware dmi-sysfs sysfs code to use default_groups
field which has been the preferred way since aa30f47cf666 ("kobject: Add
support for default attribute groups to kobj_type") so that we can soon
get rid of the obsolete default_attrs field.

Link: https://lore.kernel.org/r/20220105181719.2737782-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/dmi-sysfs.c

index 8b8127f..3a35377 100644 (file)
@@ -302,12 +302,12 @@ static struct attribute *dmi_sysfs_sel_attrs[] = {
        &dmi_sysfs_attr_sel_per_log_type_descriptor_length.attr,
        NULL,
 };
-
+ATTRIBUTE_GROUPS(dmi_sysfs_sel);
 
 static struct kobj_type dmi_system_event_log_ktype = {
        .release = dmi_entry_free,
        .sysfs_ops = &dmi_sysfs_specialize_attr_ops,
-       .default_attrs = dmi_sysfs_sel_attrs,
+       .default_groups = dmi_sysfs_sel_groups,
 };
 
 typedef u8 (*sel_io_reader)(const struct dmi_system_event_log *sel,
@@ -518,6 +518,7 @@ static struct attribute *dmi_sysfs_entry_attrs[] = {
        &dmi_sysfs_attr_entry_position.attr,
        NULL,
 };
+ATTRIBUTE_GROUPS(dmi_sysfs_entry);
 
 static ssize_t dmi_entry_raw_read_helper(struct dmi_sysfs_entry *entry,
                                         const struct dmi_header *dh,
@@ -565,7 +566,7 @@ static void dmi_sysfs_entry_release(struct kobject *kobj)
 static struct kobj_type dmi_sysfs_entry_ktype = {
        .release = dmi_sysfs_entry_release,
        .sysfs_ops = &dmi_sysfs_attr_ops,
-       .default_attrs = dmi_sysfs_entry_attrs,
+       .default_groups = dmi_sysfs_entry_groups,
 };
 
 static struct kset *dmi_kset;