node: set process._eventsCount to 0 on startup
authorEvan Lucas <evanlucas@me.com>
Fri, 12 Feb 2016 21:14:42 +0000 (15:14 -0600)
committerMyles Borins <mborins@us.ibm.com>
Wed, 2 Mar 2016 22:01:11 +0000 (14:01 -0800)
process is an EventEmitter. There are operations that increment and
decrement the _eventsCount property of an EventEmitter.
process._eventsCount would previously get set to NaN. This change makes
process._eventsCount be calculated as expected.

PR-URL: https://github.com/nodejs/node/pull/5208
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
src/node.js
test/parallel/test-process-emit.js

index f629486..8914e85 100644 (file)
@@ -12,6 +12,7 @@
 
   function startup() {
     var EventEmitter = NativeModule.require('events');
+    process._eventsCount = 0;
 
     Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
       constructor: {
index ce7d441..f4f6d54 100644 (file)
@@ -18,3 +18,5 @@ process.on('SIGPIPE', common.mustCall((data) => {
 process.emit('normal', 'normalData');
 process.emit(sym, 'symbolData');
 process.emit('SIGPIPE', 'signalData');
+
+assert.strictEqual(isNaN(process._eventsCount), false);