ARM: OMAP1: call platform_device_put() in error case in omap1_dm_timer_init()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 19 Jan 2023 09:57:54 +0000 (11:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:38 +0000 (09:32 +0100)
[ Upstream commit 0414a100d6ab32721efa70ab55524540fdfe0ede ]

If platform_device_add() is not called or failed, it should call
platform_device_put() in error case.

Fixes: 97933d6ced60 ("ARM: OMAP1: dmtimer: conversion to platform devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Message-Id: <20220701094602.2365099-1-yangyingliang@huawei.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap1/timer.c

index f5cd4bb..81a912c 100644 (file)
@@ -158,7 +158,7 @@ err_free_pdata:
        kfree(pdata);
 
 err_free_pdev:
-       platform_device_unregister(pdev);
+       platform_device_put(pdev);
 
        return ret;
 }