Shut up compiler warning
authorPeter Hutterer <peter.hutterer@who-t.net>
Tue, 18 Mar 2014 03:44:39 +0000 (13:44 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Tue, 18 Mar 2014 23:36:41 +0000 (09:36 +1000)
Triggered with -O

../libevdev/libevdev.c: In function ‘libevdev_has_event_code’:
../libevdev/libevdev-util.h:58:20: warning: ‘mask’ may be used uninitialized
in this function [-Wmaybe-uninitialized]

Optimisation clearly shuffles things around here: in the code, if no max is
found, we return -1 and bail out before we access mask.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
libevdev/libevdev.c

index 0730d9912814b97a91631f59b056424672ac2872..c617756ca82261c7056a56db4fb7f5257ef23cd2 100644 (file)
@@ -1078,7 +1078,7 @@ libevdev_has_event_type(const struct libevdev *dev, unsigned int type)
 LIBEVDEV_EXPORT int
 libevdev_has_event_code(const struct libevdev *dev, unsigned int type, unsigned int code)
 {
-       const unsigned long *mask;
+       const unsigned long *mask = NULL;
        int max;
 
        if (!libevdev_has_event_type(dev, type))