2003-08-04 Andrew Cagney <cagney@redhat.com>

	* monitor.h (monitor_dump_reg_block): Remove ATTR_FORMAT.
	* cli/cli-script.c (define_command): Call query directly, instead
	of passing it a buffer.
	* ocd.c (ocd_error): Pass error a constant format string.
	* remote-mips.c (mips_error): Use fputs_filtered.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c81d7f6..83ae7c4 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2003-08-04  Andrew Cagney  <cagney@redhat.com>
 
+       * monitor.h (monitor_dump_reg_block): Remove ATTR_FORMAT.
+       * cli/cli-script.c (define_command): Call query directly, instead
+       of passing it a buffer.
+       * ocd.c (ocd_error): Pass error a constant format string.
+       * remote-mips.c (mips_error): Use fputs_filtered.
+
        * solib-svr4.c (_initialize_svr4_solib): Update
        register_gdbarch_data call.
        * mips-linux-tdep.c (_initialize_mips_linux_tdep): Ditto.

diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index 0f789bb..ab69ca4 100644 (file)
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -1092,11 +1092,12 @@ define_command (char *comname, int from_tty)
 
   if (c)
     {
+      int q;
       if (c->class == class_user || c->class == class_alias)
-       tem = "Redefine command \"%s\"? ";
+       q = query ("Redefine command \"%s\"? ", c->name);
       else
-       tem = "Really redefine built-in command \"%s\"? ";
-      if (!query (tem, c->name))
+       q = query ("Really redefine built-in command \"%s\"? ", c->name);
+      if (!q)
        error ("Command \"%s\" not redefined.", c->name);
     }
 

diff --git a/gdb/monitor.h b/gdb/monitor.h
index 9141450..2f8ca22 100644 (file)
--- a/gdb/monitor.h
+++ b/gdb/monitor.h
@@ -245,8 +245,12 @@ extern void monitor_close (int quitting);
 extern char *monitor_supply_register (int regno, char *valstr);
 extern int monitor_expect (char *prompt, char *buf, int buflen);
 extern int monitor_expect_prompt (char *buf, int buflen);
-extern void monitor_printf (char *, ...) ATTR_FORMAT (printf, 1, 2);
-extern void monitor_printf_noecho (char *, ...) ATTR_FORMAT (printf, 1, 2);
+/* Note: The variable argument functions monitor_printf and
+   monitor_printf_noecho vararg do not take take standard format style
+   arguments.  Instead they take custom formats interpretered directly
+   by monitor_vsprintf.  */
+extern void monitor_printf (char *, ...);
+extern void monitor_printf_noecho (char *, ...);
 extern void monitor_write (char *buf, int buflen);
 extern int monitor_readchar (void);
 extern char *monitor_get_dev_name (void);

diff --git a/gdb/ocd.c b/gdb/ocd.c
index 3c8d5d2..6b38159 100644 (file)
--- a/gdb/ocd.c
+++ b/gdb/ocd.c
@@ -146,7 +146,7 @@ ocd_error (char *s, int error_code)
       s = buf;
     }
 
-  error (s);
+  error ("%s", s);
 }
 
 /*  Return nonzero if the thread TH is still alive on the remote system.  */

diff --git a/gdb/remote-mips.c b/gdb/remote-mips.c
index 96f3972..c50c504 100644 (file)
--- a/gdb/remote-mips.c
+++ b/gdb/remote-mips.c
@@ -483,7 +483,7 @@ mips_error (char *string,...)
   wrap_here ("");              /* Force out any buffered output */
   gdb_flush (gdb_stdout);
   if (error_pre_print)
-    fprintf_filtered (gdb_stderr, error_pre_print);
+    fputs_filtered (error_pre_print, gdb_stderr);
   vfprintf_filtered (gdb_stderr, string, args);
   fprintf_filtered (gdb_stderr, "\n");
   va_end (args);