usb: mtu3: simplify mtu3_req_complete()
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Mon, 27 Jul 2020 07:15:00 +0000 (15:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 14:53:59 +0000 (16:53 +0200)
Use argument req directly instead of mreq->request, they
are the same usb request.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1595834101-13094-11-git-send-email-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/mtu3/mtu3_gadget.c

index 73a8536..1de5c9a 100644 (file)
@@ -15,15 +15,13 @@ void mtu3_req_complete(struct mtu3_ep *mep,
 __releases(mep->mtu->lock)
 __acquires(mep->mtu->lock)
 {
-       struct mtu3_request *mreq;
-       struct mtu3 *mtu;
+       struct mtu3_request *mreq = to_mtu3_request(req);
+       struct mtu3 *mtu = mreq->mtu;
 
-       mreq = to_mtu3_request(req);
        list_del(&mreq->list);
-       if (mreq->request.status == -EINPROGRESS)
-               mreq->request.status = status;
+       if (req->status == -EINPROGRESS)
+               req->status = status;
 
-       mtu = mreq->mtu;
        trace_mtu3_req_complete(mreq);
        spin_unlock(&mtu->lock);
 
@@ -31,11 +29,10 @@ __acquires(mep->mtu->lock)
        if (mep->epnum)
                usb_gadget_unmap_request(&mtu->g, req, mep->is_in);
 
-       dev_dbg(mtu->dev, "%s complete req: %p, sts %d, %d/%d\n", mep->name,
-               req, req->status, mreq->request.actual, mreq->request.length);
-
-       usb_gadget_giveback_request(&mep->ep, &mreq->request);
+       dev_dbg(mtu->dev, "%s complete req: %p, sts %d, %d/%d\n",
+               mep->name, req, req->status, req->actual, req->length);
 
+       usb_gadget_giveback_request(&mep->ep, req);
        spin_lock(&mtu->lock);
 }