ALSA: pci/rme9652/hdspm: remove always true condition
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 2 Jul 2020 19:35:56 +0000 (14:35 -0500)
committerTakashi Iwai <tiwai@suse.de>
Tue, 7 Jul 2020 10:10:50 +0000 (12:10 +0200)
Fix W=1 warning:

sound/pci/rme9652/hdspm.c: In function ‘hdspm_autosync_ref’:
sound/pci/rme9652/hdspm.c:3030:16: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
 3030 |   if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) &&
      |                ^~

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200702193604.169059-16-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/rme9652/hdspm.c

index f7cda90..0fa49f4 100644 (file)
@@ -3027,8 +3027,8 @@ static int hdspm_autosync_ref(struct hdspm *hdspm)
 
                unsigned int status = hdspm_read(hdspm, HDSPM_statusRegister);
                unsigned int syncref = (status >> HDSPM_AES32_syncref_bit) & 0xF;
-               if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) &&
-                               (syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN)) {
+               /* syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD is always true */
+               if (syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN) {
                        return syncref;
                }
                return HDSPM_AES32_AUTOSYNC_FROM_NONE;