drm/i915: warn about invalid pfit modes
authorJesse Barnes <jbarnes@virtuousgeek.org>
Thu, 25 Apr 2013 19:55:03 +0000 (12:55 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 25 Apr 2013 20:18:22 +0000 (22:18 +0200)
We prevent invalid ones from getting here in the first place, but it
doesn't hurt to have an extra sanity check.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_panel.c

index 00f31f7..2526326 100644 (file)
@@ -58,7 +58,6 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,
                        struct intel_crtc_config *pipe_config,
                        int fitting_mode)
 {
-       struct drm_i915_private *dev_priv = intel_crtc->base.dev->dev_private;
        struct drm_display_mode *mode, *adjusted_mode;
        int x, y, width, height;
 
@@ -107,12 +106,15 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,
                }
                break;
 
-       default:
        case DRM_MODE_SCALE_FULLSCREEN:
                x = y = 0;
                width = adjusted_mode->hdisplay;
                height = adjusted_mode->vdisplay;
                break;
+
+       default:
+               WARN(1, "bad panel fit mode: %d\n", fitting_mode);
+               return;
        }
 
 done:
@@ -267,7 +269,6 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
                        }
                }
                break;
-       default:
        case DRM_MODE_SCALE_FULLSCREEN:
                /*
                 * Full scaling, even if it changes the aspect ratio.
@@ -285,6 +286,9 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
                                                 HORIZ_INTERP_BILINEAR);
                }
                break;
+       default:
+               WARN(1, "bad panel fit mode: %d\n", fitting_mode);
+               return;
        }
 
        /* 965+ wants fuzzy fitting */