Revert "Mark colour_log_formatter methods as override" 67/220767/1 accepted/tizen/5.5/unified/20200105.221111 submit/tizen_5.5/20200103.003447
authorTomasz Swierczek <t.swierczek@samsung.com>
Mon, 23 Dec 2019 05:58:53 +0000 (06:58 +0100)
committerTomasz Swierczek <t.swierczek@samsung.com>
Mon, 23 Dec 2019 05:59:12 +0000 (06:59 +0100)
This reverts commit 31bba785d8f2c84207f68e862751ec5fc421c2c5.

With older versions of boost, build-time errors occur with this patch
(marked 'override', but does not override).

Change-Id: I1dff4b41703a2896de60c1dbae82536f83636c04

test/colour_log_formatter.cpp
test/colour_log_formatter.h

index b13c139a0d82048297ca37c7c0415d8cbec6f1f4..c39e44e9a2248773aa25feed096f928e00e51af5 100644 (file)
@@ -314,31 +314,30 @@ colour_log_formatter::entry_context_start(std::ostream& os, boost::unit_test::lo
     (void)os;
     (void)l;
 }
-#if BOOST_VERSION >= 106500
 void
-colour_log_formatter::log_entry_context(std::ostream& os, log_level l, const_string value)
+colour_log_formatter::log_entry_context(std::ostream& os, boost::unit_test::const_string value)
 {
     (void)os;
-    (void)l;
     (void)value;
 }
 void
-colour_log_formatter::entry_context_finish(std::ostream& os, log_level l)
+colour_log_formatter::entry_context_finish(std::ostream& os)
 {
     (void)os;
-    (void)l;
 }
-#else
+#if BOOST_VERSION >= 106501
 void
-colour_log_formatter::log_entry_context(std::ostream& os, boost::unit_test::const_string value)
+colour_log_formatter::log_entry_context(std::ostream& os, log_level l, const_string value)
 {
     (void)os;
+    (void)l;
     (void)value;
 }
 void
-colour_log_formatter::entry_context_finish(std::ostream& os)
+colour_log_formatter::entry_context_finish(std::ostream& os, log_level l)
 {
     (void)os;
+    (void)l;
 }
 #endif
 //____________________________________________________________________________//
index e780bdff0087138aee879575bcdf60bdc058130b..69bd953ee43781ed4d8d596bbcf05309069580bb 100644 (file)
@@ -20,8 +20,8 @@ class colour_log_formatter : public boost::unit_test::unit_test_log_formatter {
 public:
     // Formatter interface
     colour_log_formatter() : m_isTestCaseFailed(false) {}
-    void log_start(std::ostream &, boost::unit_test::counter_t test_cases_amount) override;
-    void log_finish(std::ostream &) override;
+    void log_start(std::ostream &, boost::unit_test::counter_t test_cases_amount);
+    void log_finish(std::ostream &);
 
 #if BOOST_VERSION >= 107000
     void log_build_info(std::ostream &, bool) override;
@@ -29,30 +29,29 @@ public:
     void log_build_info(std::ostream &) override;
 #endif
 
-    void test_unit_start(std::ostream &, boost::unit_test::test_unit const &tu) override;
+    void test_unit_start(std::ostream &, boost::unit_test::test_unit const &tu);
     void test_unit_finish(std::ostream &, boost::unit_test::test_unit const &tu,
-                          unsigned long elapsed) override;
-    void test_unit_skipped(std::ostream &, boost::unit_test::test_unit const &tu) override;
+                          unsigned long elapsed);
+    void test_unit_skipped(std::ostream &, boost::unit_test::test_unit const &tu);
 
     void log_exception_start(std::ostream &,
                              boost::unit_test::log_checkpoint_data const &,
-                             boost::execution_exception const &ex) override;
-    void log_exception_finish(std::ostream &os) override;
+                             boost::execution_exception const &ex);
+    void log_exception_finish(std::ostream &os);
 
     void log_entry_start(std::ostream &, boost::unit_test::log_entry_data const &,
-                         log_entry_types let) override;
-    void log_entry_value(std::ostream &, boost::unit_test::const_string value) override;
-    void log_entry_value(std::ostream &, boost::unit_test::lazy_ostream const &value) override;
-    void log_entry_finish(std::ostream &) override;
-
-    void entry_context_start(std::ostream& os, boost::unit_test::log_level l) override;
-
-#if BOOST_VERSION >= 106500
-    void log_entry_context(std::ostream& os, boost::unit_test::log_level l, boost::unit_test::const_string value) override;
-    void entry_context_finish(std::ostream& os, boost::unit_test::log_level l) override;
-#else
-    void log_entry_context(std::ostream& os, boost::unit_test::const_string value) override;
-    void entry_context_finish(std::ostream& os) override;
+                         log_entry_types let);
+    void log_entry_value(std::ostream &, boost::unit_test::const_string value);
+    void log_entry_value(std::ostream &, boost::unit_test::lazy_ostream const &value);
+    void log_entry_finish(std::ostream &);
+
+    void entry_context_start(std::ostream& os, boost::unit_test::log_level l);
+    void log_entry_context(std::ostream& os, boost::unit_test::const_string value);
+    void entry_context_finish(std::ostream& os);
+
+#if BOOST_VERSION >= 106501
+    void log_entry_context(std::ostream& os, boost::unit_test::log_level l, boost::unit_test::const_string value);
+    void entry_context_finish(std::ostream& os, boost::unit_test::log_level l);
 #endif
 
 private: