i2c: muxes: Fix return value check in mule_i2c_mux_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 26 Oct 2024 03:09:42 +0000 (11:09 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 5 Nov 2024 14:17:34 +0000 (15:17 +0100)
If dev_get_regmap() fails, it returns NULL pointer not ERR_PTR(),
replace IS_ERR() with NULL pointer check, and return -ENODEV.

Fixes: d0f8e97866bf ("i2c: muxes: add support for tsd,mule-i2c multiplexer")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/muxes/i2c-mux-mule.c

index 8e942470b35f214ef8faf8ca87db546e85166ab0..284ff4afeeacab074a34706e8cc4f6eccd683fed 100644 (file)
@@ -66,8 +66,8 @@ static int mule_i2c_mux_probe(struct platform_device *pdev)
        priv = i2c_mux_priv(muxc);
 
        priv->regmap = dev_get_regmap(mux_dev->parent, NULL);
-       if (IS_ERR(priv->regmap))
-               return dev_err_probe(mux_dev, PTR_ERR(priv->regmap),
+       if (!priv->regmap)
+               return dev_err_probe(mux_dev, -ENODEV,
                                     "No parent i2c register map\n");
 
        platform_set_drvdata(pdev, muxc);