projects / platform / upstream / VK-GL-CTS.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a1afe61)
Fix SPIRV validation for decoration tests
authorGraeme Leese <gleese@broadcom.com>
Thu, 18 Aug 2022 11:36:28 +0000 (12:36 +0100)
committerMatthew Netsch <quic_mnetsch@quicinc.com>
Thu, 25 Aug 2022 16:36:36 +0000 (16:36 +0000)
The decoration matching tests were incorrectly using Flat and
NoPerspective decoration on vertex inputs. The validator has been
updated to catch these errors, so the tests now cause an InternalError.

Compoennts: Vulkan
VK-GL-CTS issue: 3895
Affects: dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.flat
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.no_perspective
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.flat
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.no_perspective

Change-Id: I818868ca87d15d068430e9721204be620b28e225

external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmCrossStageInterfaceTests.cpp patch | blob | history

diff --git a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmCrossStageInterfaceTests.cpp b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmCrossStageInterfaceTests.cpp
index 767806b6497695da999049d033a244c1452e7e35..b3c6463745eb2abc37eb896e3abd84dd243d77b5 100644 (file)
--- a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmCrossStageInterfaceTests.cpp
+++ b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmCrossStageInterfaceTests.cpp
@@ -664,7 +664,6 @@ void CrossStageBasicTestsCase::initPrograms (SourceCollections& programCollectio
                decorations.push_back(Decorations("",
                                                                //Vertex
                                                                "OpDecorate %color_out Flat\n"
-                                                               "OpDecorate %color_in Flat\n"
                                                                "OpDecorate %r_float_out Flat\n"
                                                                "OpDecorate %rg_float_out Flat\n"
                                                                "OpDecorate %rgb_float_out Flat\n"
@@ -687,7 +686,6 @@ void CrossStageBasicTestsCase::initPrograms (SourceCollections& programCollectio
                                                                "OpDecorate %rgba_float_in Flat\n",
                                                                //Vertex
                                                                "OpDecorate %color_out Flat\n"
-                                                               "OpDecorate %color_in Flat\n"
                                                                "OpDecorate %r_float_out Flat\n"
                                                                "OpDecorate %rg_float_out Flat\n"
                                                                "OpDecorate %rgb_float_out Flat\n"
@@ -699,7 +697,6 @@ void CrossStageBasicTestsCase::initPrograms (SourceCollections& programCollectio
                decorations.push_back(Decorations("",
                                                                //Vertex
                                                                "OpDecorate %color_out NoPerspective\n"
-                                                               "OpDecorate %color_in NoPerspective\n"
                                                                "OpDecorate %r_float_out NoPerspective\n"
                                                                "OpDecorate %rg_float_out NoPerspective\n"
                                                                "OpDecorate %rgb_float_out NoPerspective\n"
@@ -723,7 +720,6 @@ void CrossStageBasicTestsCase::initPrograms (SourceCollections& programCollectio
                                                                "OpDecorate %rgba_float_in NoPerspective\n",
                                                                //Vertex
                                                                "OpDecorate %color_out NoPerspective\n"
-                                                               "OpDecorate %color_in NoPerspective\n"
                                                                "OpDecorate %r_float_out NoPerspective\n"
                                                                "OpDecorate %rg_float_out NoPerspective\n"
                                                                "OpDecorate %rgb_float_out NoPerspective\n"
@@ -1787,7 +1783,6 @@ void CrossStageInterfaceTestsCase::initPrograms (SourceCollections& programColle
                decorations.push_back(Decorations("",
                                                                //Vertex
                                                                "OpDecorate %color_out Flat\n"
-                                                               "OpDecorate %color_in Flat\n"
                                                                "OpMemberDecorate %block_out 0 Flat\n"
                                                                "OpMemberDecorate %block_out 1 Flat\n",
                                                                ""));
@@ -1804,7 +1799,6 @@ void CrossStageInterfaceTestsCase::initPrograms (SourceCollections& programColle
                                                                "OpMemberDecorate %block_in 1 Flat\n",
                                                                //Vertex
                                                                "OpDecorate %color_out Flat\n"
-                                                               "OpDecorate %color_in Flat\n"
                                                                "OpMemberDecorate %block_out 0 Flat\n"
                                                                "OpMemberDecorate %block_out 1 Flat\n",
                                                                ""));
@@ -1814,7 +1808,6 @@ void CrossStageInterfaceTestsCase::initPrograms (SourceCollections& programColle
                decorations.push_back(Decorations("",
                                                                //Vertex
                                                                "OpDecorate %color_out NoPerspective\n"
-                                                               "OpDecorate %color_in NoPerspective\n"
                                                                "OpMemberDecorate %block_out 0 NoPerspective\n"
                                                                "OpMemberDecorate %block_out 1 NoPerspective\n",
                                                                ""));
@@ -1832,7 +1825,6 @@ void CrossStageInterfaceTestsCase::initPrograms (SourceCollections& programColle
                                                                "OpMemberDecorate %block_in 1 NoPerspective\n",
                                                                //Vertex
                                                                "OpDecorate %color_out NoPerspective\n"
-                                                               "OpDecorate %color_in NoPerspective\n"
                                                                "OpMemberDecorate %block_out 0 NoPerspective\n"
                                                                "OpMemberDecorate %block_out 1 NoPerspective\n",
                                                                ""));
Domain: Graphics System / GL;