device_select: close dri3 fd after using it.
authorDave Airlie <airlied@redhat.com>
Wed, 6 Oct 2021 07:13:46 +0000 (17:13 +1000)
committerDave Airlie <airlied@redhat.com>
Wed, 6 Oct 2021 08:24:54 +0000 (18:24 +1000)
This can leak and causes crashes in some CTS test groups
dEQP-VK.wsi.xcb.incremental_present*

Fixes: 9bc5b2d169d3 ("vulkan: add initial device selection layer. (v6.1)")
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13215>

src/vulkan/device-select-layer/device_select_x11.c

index 93b39f2..b17402e 100644 (file)
@@ -93,6 +93,7 @@ int device_select_find_xcb_pci_default(struct device_pci_info *devices, uint32_t
 
   drmDevicePtr xdev;
   int ret = drmGetDevice2(dri3_fd, 0, &xdev);
+  close(dri3_fd);
   if (ret < 0)
     goto out;