platform: template: Improve comments for FW_JUMP_ADDR and FW_PAYLOAD_OFFSET
authorAnup Patel <anup.patel@wdc.com>
Fri, 8 Feb 2019 04:16:12 +0000 (09:46 +0530)
committerAnup Patel <anup@brainfault.org>
Tue, 12 Feb 2019 10:25:15 +0000 (15:55 +0530)
Both FW_JUMP_ADDR and FW_PAYLOAD_OFFSET, should be:
1. 4MB aligned for 32bit system
2. 2MB aligned for 64bit system

Explicitly specify the above details in config.mk comments
for template platform.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
platform/template/config.mk

index 2f2b895..3c85af7 100644 (file)
@@ -41,8 +41,13 @@ FW_TEXT_START=0x80000000
 # as needed.
 #
 FW_JUMP=<y|n>
-# This needs to be 4MB alligned for 32-bit support
-FW_JUMP_ADDR=0x80400000
+# This needs to be 4MB aligned for 32-bit support
+# This needs to be 2MB aligned for 64-bit support
+# ifeq ($(OPENSBI_CC_XLEN), 32)
+# FW_JUMP_ADDR=0x80400000
+# else
+# FW_JUMP_ADDR=0x80200000
+# endif
 # FW_JUMP_FDT_ADDR=0x82200000
 
 #
@@ -51,8 +56,13 @@ FW_JUMP_ADDR=0x80400000
 # as needed.
 #
 FW_PAYLOAD=<y|n>
-# This needs to be 4MB alligned for 32-bit support
+# This needs to be 4MB aligned for 32-bit support
+# This needs to be 2MB aligned for 64-bit support
+ifeq ($(OPENSBI_CC_XLEN), 32)
 FW_PAYLOAD_OFFSET=0x400000
+else
+FW_PAYLOAD_OFFSET=0x200000
+endif
 # FW_PAYLOAD_ALIGN=0x1000
 # FW_PAYLOAD_PATH="path to next boot stage binary image file"
 # FW_PAYLOAD_FDT_PATH="path to platform flattened device tree file"