re PR fortran/91564 (ICE in gimplify_expr, at gimplify.c:14147)

2019-08-28  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/91564
	* check.c (gfc_check_kill_sub): Additional checks on status dummy
	argument.

2019-08-28  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/91564
	* gfortran.dg/pr91564.f90: New test.

From-SVN: r275005

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 6b760ce..b118913 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-28  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/91564
+       * check.c (gfc_check_kill_sub): Additional checks on status dummy
+       argument.
+
 2019-08-28  Mark Eggleston  <mark.eggleston@codethink.com>
 
        * intrinsics.text: Corrected stated standard for intrinsics

diff --git a/gcc/fortran/check.c b/gcc/fortran/check.c
index 2bd8bc3..a04f9fb 100644 (file)
--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -3301,6 +3301,22 @@ gfc_check_kill_sub (gfc_expr *pid, gfc_expr *sig, gfc_expr *status)
 
       if (!scalar_check (status, 2))
        return false;
+
+      if (status->expr_type != EXPR_VARIABLE)
+       {
+         gfc_error ("STATUS at %L shall be an INTENT(OUT) variable",
+                    &status->where);
+         return false;
+       }
+
+      if (status->expr_type == EXPR_VARIABLE
+         && status->symtree && status->symtree->n.sym
+         && status->symtree->n.sym->attr.intent == INTENT_IN)
+       {
+         gfc_error ("%qs at %L shall be an INTENT(OUT) variable",
+                    status->symtree->name, &status->where);
+         return false;
+       }
     }
 
   return true;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 0e7c31b..06d8b1b 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-28  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/91564
+       * gfortran.dg/pr91564.f90: New test.
+
 2019-08-28  Martin Sebor  <msebor@redhat.com>
 
        PR tree-optimization/91457

diff --git a/gcc/testsuite/gfortran.dg/pr91564.f90 b/gcc/testsuite/gfortran.dg/pr91564.f90
new file mode 100644 (file)
index 0000000..57783ab
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr91564.f90
@@ -0,0 +1,16 @@
+! { dg-do compile }
+! PR fortran/91564
+! Contributed by Gerhard Steinmetz.
+program p
+   integer i, j
+   call kill (1, 2, 3)        ! { dg-error "shall be an INTENT" }
+   i = 42
+   call bar(i, j)
+end
+
+subroutine bar(n, m)
+   integer, intent(in) :: n
+   integer, intent(inout) :: m
+   call kill (1, 3, n)        ! { dg-error "shall be an INTENT" }
+   call kill (1, 3, m)
+end subroutine bar