Merge pull request #55 from xamarin/warnings-WP8-0114
authorE.Z. Hart <hartez@users.noreply.github.com>
Thu, 7 Apr 2016 01:58:23 +0000 (19:58 -0600)
committerSamantha Houts <samantha@teamredwall.com>
Thu, 7 Apr 2016 01:58:23 +0000 (18:58 -0700)
Remove 0114 supression from Platform.WP8; fix warnings

Xamarin.Forms.Platform.WP8/NavigationPageRenderer.cs
Xamarin.Forms.Platform.WP8/Xamarin.Forms.Platform.WP8.csproj

index 6f29010..35a77f2 100644 (file)
@@ -84,7 +84,7 @@ namespace Xamarin.Forms.Platform.WinPhone
                        return stack;
                }
 
-               void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
+               protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
                {
                        if (e.PropertyName != "Parent" || Element.RealParent != null)
                                return;
index 2cab594..b8b2c4f 100644 (file)
@@ -32,7 +32,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <NoWarn>0114;4014;0618;0219;0067</NoWarn>
+    <NoWarn>4014;0618;0219;0067</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>