[ACR-1627] Remove restriction for packet ref/unref/destroy APIs

Previously, the application has no idea that the media packet
from other module is created by which API.(media_packet_create() or media_packet_new())
So, it could not be decided to call which release API(media_packet_destroy() or media_packet_unref()).
With this patch, application does not need to care about it by removing the restriction.

[Version] 0.1.45
[Issue Type] Remove restriction

Change-Id: I5654583001dab8f3a9ddd2905e612e58e5ffb0b2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>

diff --git a/include/media_packet.h b/include/media_packet.h
index bd4fb7a2fe393e5c16515ad167fedf175182c2bc..27a681c8c665247ff530ae6b5a28fe0883fca6da 100644 (file)
--- a/include/media_packet.h
+++ b/include/media_packet.h
@@ -339,10 +339,6 @@ int media_packet_new_from_external_memory(media_format_h fmt, void *mem_ptr, uin
 /**
  * @brief Increases reference count of a media packet handle.
  * @since_tizen 6.5
- * @remarks It will return #MEDIA_PACKET_ERROR_INVALID_OPERATION \n
- *          if the media packet handle is from media_packet_create(), \n
- *          media_packet_create_alloc(), media_packet_create_from_tbm_surface() \n
- *          and media_packet_create_from_external_memory().
  * @param[in] packet The media packet handle
  * @return @c 0 on success, otherwise a negative error value
  * @retval #MEDIA_PACKET_ERROR_NONE Successful
@@ -355,10 +351,6 @@ int media_packet_ref(media_packet_h packet);
 /**
  * @brief Decreases reference count of a media packet handle.
  * @since_tizen 6.5
- * @remarks It will return #MEDIA_PACKET_ERROR_INVALID_OPERATION \n
- *          if the media packet handle is from media_packet_create(), \n
- *          media_packet_create_alloc(), media_packet_create_from_tbm_surface() \n
- *          and media_packet_create_from_external_memory().
  * @param[in] packet The media packet handle
  * @return @c 0 on success, otherwise a negative error value
  * @retval #MEDIA_PACKET_ERROR_NONE Successful
@@ -1096,13 +1088,9 @@ int media_packet_get_codec_data(media_packet_h packet, void **codec_data, unsign
 /**
  * @deprecated Deprecated since 6.5. Use media_packet_unref() instead.
  * @brief Destroys the media packet handle.
- * @details The registered finalize_callback() function will be invoked to destroy the media packet handle.
+ * @details The registered media_packet_finalize_cb() or media_packet_dispose_cb() \n
+ *          will be invoked when @a packet is released. (since 6.5)
  * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif
- * @remarks It will return #MEDIA_PACKET_ERROR_INVALID_OPERATION \n
- *          if the media packet handle is from media_packet_new(), \n
- *          media_packet_new_alloc(), media_packet_new_from_tbm_surface() \n
- *          and media_packet_new_from_external_memory(). (since 6.5)
- *
  * @param[in] packet  The handle to media packet to be destroyed
  *
  * @return @c 0 on success,

diff --git a/packaging/capi-media-tool.spec b/packaging/capi-media-tool.spec
index 56268568c7398e4c2645e3bb78de23191285389b..be0538d2a1fd876aa72bef492523ac8b88c80ebd 100755 (executable)
--- a/packaging/capi-media-tool.spec
+++ b/packaging/capi-media-tool.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-tool
 Summary:    A Core API media tool library in Tizen Native API
-Version:    0.1.44
+Version:    0.1.45
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/media_packet.c b/src/media_packet.c
index 3d536e8852495a91e99feb692d892ac28109e1d6..bee5e0eba598b42078bc4f4efd17e3312bc3645e 100644 (file)
--- a/src/media_packet.c
+++ b/src/media_packet.c
@@ -301,11 +301,6 @@ int media_packet_ref(media_packet_h packet)
 
        MEDIA_PACKET_INSTANCE_CHECK(handle);
 
-       if (!handle->is_from_new) {
-               LOGE("It's from media_packet_create(), it should be from media_packet_new()");
-               return MEDIA_PACKET_ERROR_INVALID_OPERATION;
-       }
-
        g_mutex_lock(&handle->ref_lock);
 
        if (handle->ref_count < 1) {
@@ -331,11 +326,6 @@ int media_packet_unref(media_packet_h packet)
 
        MEDIA_PACKET_INSTANCE_CHECK(handle);
 
-       if (!handle->is_from_new) {
-               LOGE("It's from media_packet_create(), it should be from media_packet_new()");
-               return MEDIA_PACKET_ERROR_INVALID_OPERATION;
-       }
-
        return __pkt_destroy(handle);
 }
 
@@ -1316,11 +1306,6 @@ int media_packet_destroy(media_packet_h packet)
 
        MEDIA_PACKET_INSTANCE_CHECK(handle);
 
-       if (handle->is_from_new) {
-               LOGE("It's from media_packet_new() APIs, so should be released with media_packet_unref()");
-               return MEDIA_PACKET_ERROR_INVALID_OPERATION;
-       }
-
        return __pkt_destroy(handle);
 }