staging: iio: adc: ad7192: fail probe on get_voltage
authorAlexandru Tachici <alexandru.tachici@analog.com>
Wed, 12 Feb 2020 16:17:17 +0000 (18:17 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 Mar 2020 17:28:32 +0000 (17:28 +0000)
This patch makes the ad7192_probe fail in case
regulator_get_voltage will return an error or voltage
is set to 0.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/adc/ad7192.c

index bf3e2a9..41da8b4 100644 (file)
@@ -899,10 +899,13 @@ static int ad7192_probe(struct spi_device *spi)
 
        voltage_uv = regulator_get_voltage(st->avdd);
 
-       if (voltage_uv)
+       if (voltage_uv > 0) {
                st->int_vref_mv = voltage_uv / 1000;
-       else
+       } else {
+               ret = voltage_uv;
                dev_err(&spi->dev, "Device tree error, reference voltage undefined\n");
+               goto error_disable_avdd;
+       }
 
        spi_set_drvdata(spi, indio_dev);
        st->devid = spi_get_device_id(spi)->driver_data;