result.AppendErrorWithFormat(
"Function name regular expression could not be compiled: %s",
llvm::toString(std::move(err)).c_str());
+ // Check if the incorrect regex looks like a globbing expression and
+ // warn the user about it.
+ if (!m_options.m_func_regexp.empty()) {
+ if (m_options.m_func_regexp[0] == '*' ||
+ m_options.m_func_regexp[0] == '?')
+ result.AppendWarning(
+ "Function name regex does not accept glob patterns.");
+ }
result.SetStatus(eReturnStatusFailed);
return false;
}
self.expect("breakpoint set --func-regex (", error=True,
substrs=["error: Function name regular expression could " +
"not be compiled: parentheses not balanced"])
+
+ # Point out if looks like the user provided a globbing expression.
+ self.expect("breakpoint set --func-regex *a", error=True,
+ substrs=["error: Function name regular expression could " +
+ "not be compiled: repetition-operator operand invalid",
+ "warning: Function name regex does not accept glob patterns."])
+ self.expect("breakpoint set --func-regex ?a", error=True,
+ substrs=["error: Function name regular expression could " +
+ "not be compiled: repetition-operator operand invalid",
+ "warning: Function name regex does not accept glob patterns."])
+ # Make sure that warning is only shown for invalid regular expressions
+ # that look like a globbing expression (i.e., they have a leading * or ?).
+ self.expect("breakpoint set --func-regex a*+", error=True, matching=False,
+ substrs=["warning: Function name regex does not accept glob patterns."])
+ self.expect("breakpoint set --func-regex a?+", error=True, matching=False,
+ substrs=["warning: Function name regex does not accept glob patterns."])