AppInstaller logic export

This commit gather the logic of choosing proper steps sequence
to app-installer repository. All backends have to prepare their
own sequences for each pkgmgr request. The default implementation
of such methods is provided and there is no need for overriding
each function in backends.

    Submit together:
     - https://review.tizen.org/gerrit/#/c/93998/
     - https://review.tizen.org/gerrit/#/c/94000/

Change-Id: I5cdf18ac0100437819b9cb7d6c435e4668ea3643
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>

diff --git a/src/tpk/tpk_installer.cc b/src/tpk/tpk_installer.cc
index 007298ec39d99dce7a9f2d75d17ebed5d9b862a2..36694d77fa3743172db78e8a9eeadbbb33c901e7 100644 (file)
--- a/src/tpk/tpk_installer.cc
+++ b/src/tpk/tpk_installer.cc
@@ -106,76 +106,12 @@ namespace tpk {
 
 TpkInstaller::TpkInstaller(common_installer::PkgMgrPtr pkgmgr)
     : AppInstaller(kPkgType, pkgmgr) {
-  Prepare();
+  Init();
 }
 
 TpkInstaller::~TpkInstaller() {
 }
 
-void TpkInstaller::Prepare() {
-  switch (pkgmgr_->GetRequestType()) {
-    case ci::RequestType::Install:
-      InstallSteps();
-      break;
-    case ci::RequestType::Update:
-      UpdateSteps();
-      break;
-    case ci::RequestType::Uninstall:
-      UninstallSteps();
-      break;
-    case ci::RequestType::Reinstall:
-      ReinstallSteps();
-      break;
-    case ci::RequestType::Delta:
-      DeltaSteps();
-      break;
-    case ci::RequestType::Move:
-      MoveSteps();
-      break;
-    case ci::RequestType::Recovery:
-      RecoverySteps();
-      break;
-    case ci::RequestType::MountInstall:
-      MountInstallSteps();
-      break;
-    case ci::RequestType::MountUpdate:
-      MountUpdateSteps();
-      break;
-    case ci::RequestType::ManifestDirectInstall:
-      ManifestDirectInstallSteps();
-      break;
-    case ci::RequestType::ManifestDirectUpdate:
-      ManifestDirectUpdateSteps();
-      break;
-    case ci::RequestType::ManifestPartialInstall:
-      ManifestPartialInstallSteps();
-      break;
-    case ci::RequestType::ManifestPartialUpdate:
-      ManifestPartialUpdateSteps();
-      break;
-    case ci::RequestType::PartialUninstall:
-      PartialUninstallSteps();
-      break;
-    case ci::RequestType::ReadonlyUpdateInstall:
-      ReadonlyUpdateInstallSteps();
-      break;
-    case ci::RequestType::ReadonlyUpdateUninstall:
-      ReadonlyUpdateUninstallSteps();
-      break;
-    case ci::RequestType::EnablePkg:
-      EnablePkgSteps();
-      break;
-    case ci::RequestType::DisablePkg:
-      DisablePkgSteps();
-      break;
-    case ci::RequestType::MigrateExtImg:
-      MigrateLegacyExtImageSteps();
-      break;
-    default:
-      AddStep<ci::configuration::StepFail>();
-      break;
-  }
-}
 
 void TpkInstaller::InstallSteps() {
   AddStep<ci::configuration::StepConfigure>(pkgmgr_);
@@ -726,7 +662,7 @@ void TpkInstaller::EnablePkgSteps() {
     ci::Plugin::ActionType::Install);
 }
 
-void TpkInstaller::MigrateLegacyExtImageSteps() {
+void TpkInstaller::MigrateExtImgSteps() {
   AddStep<ci::configuration::StepConfigure>(pkgmgr_);
   AddStep<ci::security::StepMigrateLegacyExtImage>();
   AddStep<ci::filesystem::StepChangeOwnershipAndPermission>();

diff --git a/src/tpk/tpk_installer.h b/src/tpk/tpk_installer.h
index 55b8d666830573405fd219212a2f1de65badf9fc..d7d479cfa15aa692792d554229469b94a4a09cfd 100644 (file)
--- a/src/tpk/tpk_installer.h
+++ b/src/tpk/tpk_installer.h
@@ -29,26 +29,25 @@ class TPK_BACKEND_EXPORT_API TpkInstaller
   void Prepare();
 
  private:
-  void InstallSteps();
-  void UpdateSteps();
-  void UninstallSteps();
-  void ReinstallSteps();
-  void DeltaSteps();
-  void MoveSteps();
-  void DisablePkgSteps();
-  void EnablePkgSteps();
-  void RecoverySteps();
-  void MountInstallSteps();
-  void MountUpdateSteps();
-  void ManifestDirectInstallSteps();
-  void ManifestDirectUpdateSteps();
-  void ManifestPartialInstallSteps();
-  void ManifestPartialUpdateSteps();
-  void PartialUninstallSteps();
-  void ReadonlyUpdateInstallSteps();
-  void ReadonlyUpdateUninstallSteps();
-  void ClearSteps();
-  void MigrateLegacyExtImageSteps();
+  void InstallSteps() override;
+  void UpdateSteps() override;
+  void UninstallSteps() override;
+  void ReinstallSteps() override;
+  void DeltaSteps() override;
+  void MoveSteps() override;
+  void RecoverySteps() override;
+  void MountInstallSteps() override;
+  void MountUpdateSteps() override;
+  void ManifestDirectInstallSteps() override;
+  void ManifestDirectUpdateSteps() override;
+  void ManifestPartialInstallSteps() override;
+  void ManifestPartialUpdateSteps() override;
+  void PartialUninstallSteps() override;
+  void ReadonlyUpdateInstallSteps() override;
+  void ReadonlyUpdateUninstallSteps() override;
+  void DisablePkgSteps() override;
+  void EnablePkgSteps() override;
+  void MigrateExtImgSteps() override;
 
   SCOPE_LOG_TAG(TpkInstaller)
 };