net/mlx5e: Fix unnecessary flow_block_cb_is_busy call
authorwenxu <wenxu@ucloud.cn>
Sat, 27 Jul 2019 14:59:55 +0000 (22:59 +0800)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 29 Jul 2019 23:40:24 +0000 (16:40 -0700)
When call flow_block_cb_is_busy. The indr_priv is guaranteed to
NULL ptr. So there is no need to call flow_bock_cb_is_busy.

Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() and use it")
Signed-off-by: wenxu <wenxu@ucloud.cn>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

index 7f747cb..496d303 100644 (file)
@@ -722,10 +722,6 @@ mlx5e_rep_indr_setup_tc_block(struct net_device *netdev,
                if (indr_priv)
                        return -EEXIST;
 
-               if (flow_block_cb_is_busy(mlx5e_rep_indr_setup_block_cb,
-                                         indr_priv, &mlx5e_block_cb_list))
-                       return -EBUSY;
-
                indr_priv = kmalloc(sizeof(*indr_priv), GFP_KERNEL);
                if (!indr_priv)
                        return -ENOMEM;