fat: delete an unnecessary check before brelse()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 25 Sep 2019 23:47:24 +0000 (16:47 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 26 Sep 2019 00:51:40 +0000 (17:51 -0700)
brelse() tests whether its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Link: http://lkml.kernel.org/r/cfff3b81-fb5d-af26-7b5e-724266509045@web.de
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fat/dir.c

index 814ad2c..054acd9 100644 (file)
@@ -88,9 +88,7 @@ static int fat__get_entry(struct inode *dir, loff_t *pos,
        int err, offset;
 
 next:
-       if (*bh)
-               brelse(*bh);
-
+       brelse(*bh);
        *bh = NULL;
        iblock = *pos >> sb->s_blocksize_bits;
        err = fat_bmap(dir, iblock, &phys, &mapped_blocks, 0, false);