btrfs-progs: deal with malloc failure in btrfs-image
authorGui Hecheng <guihc.fnst@cn.fujitsu.com>
Thu, 26 Jun 2014 02:53:02 +0000 (10:53 +0800)
committerDavid Sterba <dsterba@suse.cz>
Fri, 22 Aug 2014 12:43:11 +0000 (14:43 +0200)
Handle the malloc failure for dump_worker in the same way as
the restore worker.

Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
btrfs-image.c

index c03a98d..1a460ba 100644 (file)
@@ -107,6 +107,8 @@ struct metadump_struct {
        int done;
        int data;
        int sanitize_names;
+
+       int error;
 };
 
 struct name {
@@ -602,6 +604,14 @@ static void *dump_worker(void *data)
 
                        async->bufsize = compressBound(async->size);
                        async->buffer = malloc(async->bufsize);
+                       if (!async->buffer) {
+                               fprintf(stderr, "Error allocing buffer\n");
+                               pthread_mutex_lock(&md->mutex);
+                               if (!md->error)
+                                       md->error = -ENOMEM;
+                               pthread_mutex_unlock(&md->mutex);
+                               pthread_exit(NULL);
+                       }
 
                        ret = compress2(async->buffer,
                                         (unsigned long *)&async->bufsize,
@@ -736,7 +746,7 @@ static int write_buffers(struct metadump_struct *md, u64 *next)
                goto out;
 
        /* wait until all buffers are compressed */
-       while (md->num_items > md->num_ready) {
+       while (!err && md->num_items > md->num_ready) {
                struct timespec ts = {
                        .tv_sec = 0,
                        .tv_nsec = 10000000,
@@ -744,6 +754,13 @@ static int write_buffers(struct metadump_struct *md, u64 *next)
                pthread_mutex_unlock(&md->mutex);
                nanosleep(&ts, NULL);
                pthread_mutex_lock(&md->mutex);
+               err = md->error;
+       }
+
+       if (err) {
+               fprintf(stderr, "One of the threads errored out %s\n",
+                               strerror(err));
+               goto out;
        }
 
        /* setup and write index block */