projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a606169
)
soc: rockchip: Fix refcount leak in rockchip_grf_init
author
Miaoqian Lin
<linmq006@gmail.com>
Mon, 16 May 2022 07:20:10 +0000
(11:20 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:07 +0000
(18:36 +0200)
[ Upstream commit
9b59588d8be91c96bfb0371e912ceb4f16315dbf
]
of_find_matching_node_and_match returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes:
4c58063d4258
("soc: rockchip: add driver handling grf setup")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link:
https://lore.kernel.org/r/20220516072013.19731-1-linmq006@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/rockchip/grf.c
patch
|
blob
|
history
diff --git
a/drivers/soc/rockchip/grf.c
b/drivers/soc/rockchip/grf.c
index
494cf2b
..
343ff61
100644
(file)
--- a/
drivers/soc/rockchip/grf.c
+++ b/
drivers/soc/rockchip/grf.c
@@
-148,12
+148,14
@@
static int __init rockchip_grf_init(void)
return -ENODEV;
if (!match || !match->data) {
pr_err("%s: missing grf data\n", __func__);
+ of_node_put(np);
return -EINVAL;
}
grf_info = match->data;
grf = syscon_node_to_regmap(np);
+ of_node_put(np);
if (IS_ERR(grf)) {
pr_err("%s: could not get grf syscon\n", __func__);
return PTR_ERR(grf);