shared/tester: retain test failure status
authorPauli Virtanen <pav@iki.fi>
Sun, 21 May 2023 15:27:35 +0000 (15:27 +0000)
committerAyush Garg <ayush.garg@samsung.com>
Fri, 5 Jan 2024 13:34:03 +0000 (19:04 +0530)
If a test has called tester_test_failed, consider the test failed, even
if the test also called tester_test_passed/abort.

This avoids reporting success for misbehaving tests that call the
status report functions multiple times.

src/shared/tester.c

index 20e99bce40228a285b51c15acf61ec597338fc57..f6aff866901a7a899eb36f213235fa5affc374ed 100755 (executable)
@@ -621,6 +621,9 @@ static void test_result(enum test_result result)
                test->timeout_id = 0;
        }
 
+       if (test->result == TEST_RESULT_FAILED)
+               result = TEST_RESULT_FAILED;
+
        test->result = result;
        switch (result) {
        case TEST_RESULT_PASSED: