net/mlx5e: Utilize the entire fifo
authorRahul Rameshbabu <rrameshbabu@nvidia.com>
Tue, 14 Mar 2023 05:42:24 +0000 (22:42 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Mar 2023 05:11:50 +0000 (22:11 -0700)
Previous check was comparing against the fifo mask. The mask is size of the
fifo (power of two) minus one, so a less than or equal comparator should be
used for checking if the fifo has room for the SKB.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Link: https://lore.kernel.org/r/20230314054234.267365-6-saeed@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h

index b9c2f67..816ea83 100644 (file)
@@ -86,7 +86,7 @@ void mlx5e_free_txqsq_descs(struct mlx5e_txqsq *sq);
 static inline bool
 mlx5e_skb_fifo_has_room(struct mlx5e_skb_fifo *fifo)
 {
-       return (u16)(*fifo->pc - *fifo->cc) < fifo->mask;
+       return (u16)(*fifo->pc - *fifo->cc) <= fifo->mask;
 }
 
 static inline bool