aurum: change parameter type for improving performance

Change-Id: Ic9a55f1fcbffee7d2979397915e43312d2530f26

diff --git a/libaurum/inc/Comparer.h b/libaurum/inc/Comparer.h
index 5a8abe20d17321ec355703557ebb112e40804f2a..9f29125ea9922226f49b710e9a28586614b6ba9f 100644 (file)
--- a/libaurum/inc/Comparer.h
+++ b/libaurum/inc/Comparer.h
@@ -50,7 +50,7 @@ private:
      *
      * @since_tizen 6.5
      */
-    Comparer(const std::shared_ptr<UiDevice> device, const std::shared_ptr<UiSelector> selector,
+    Comparer(const std::shared_ptr<UiDevice>& device, const std::shared_ptr<UiSelector>& selector,
              const bool &earlyReturn);
 
     /**
@@ -73,9 +73,9 @@ public:
      *
      * @since_tizen 6.5
      */
-    static std::shared_ptr<AccessibleNode> findObject(const std::shared_ptr<UiDevice> device,
-                                                      const std::shared_ptr<UiSelector> selector,
-                                                      const std::shared_ptr<AccessibleNode> root);
+    static std::shared_ptr<AccessibleNode> findObject(const std::shared_ptr<UiDevice>& device,
+                                                      const std::shared_ptr<UiSelector>& selector,
+                                                      const std::shared_ptr<AccessibleNode>& root);
 
     /**
      * @brief find object from device.
@@ -92,8 +92,8 @@ public:
      * @since_tizen 6.5
      */
     static std::vector<std::shared_ptr<AccessibleNode>> findObjects(
-        const std::shared_ptr<UiDevice> device, const std::shared_ptr<UiSelector> selector,
-        const std::shared_ptr<AccessibleNode> root, bool earlyReturn = false);
+        const std::shared_ptr<UiDevice>& device, const std::shared_ptr<UiSelector>& selector,
+        const std::shared_ptr<AccessibleNode>& root, bool earlyReturn = false);
 
 private:
     /**
@@ -105,7 +105,7 @@ private:
      *
      * @since_tizen 6.5
      */
-    std::vector<std::shared_ptr<AccessibleNode>> findObjects(const std::shared_ptr<AccessibleNode> root);
+    std::vector<std::shared_ptr<AccessibleNode>> findObjects(const std::shared_ptr<AccessibleNode>& root);
 
     /**
      * @internal
@@ -120,12 +120,12 @@ private:
      * @since_tizen 6.5
      */
     std::vector<std::shared_ptr<AccessibleNode>> findObjects(
-        const std::shared_ptr<AccessibleNode> root, const int &index, const int &depth,
+        const std::shared_ptr<AccessibleNode>& root, const int &index, const int &depth,
         std::list<std::shared_ptr<PartialMatch>> &partialMatches);
 
 private:
-    const std::shared_ptr<UiDevice> mDevice;
-    const std::shared_ptr<UiSelector> mSelector;
+    const std::shared_ptr<UiDevice>& mDevice;
+    const std::shared_ptr<UiSelector>& mSelector;
     bool mEarlyReturn;
 };
 

diff --git a/libaurum/src/Comparer.cc b/libaurum/src/Comparer.cc
index 517f05f8ec4ac9e97e0861e92a480cbfa779a581..fa09542a7ff76a32afc3493ba9cf1012703dcc68 100644 (file)
--- a/libaurum/src/Comparer.cc
+++ b/libaurum/src/Comparer.cc
@@ -19,7 +19,7 @@
 
 using namespace Aurum;
 
-Comparer::Comparer(const std::shared_ptr<UiDevice> device, const std::shared_ptr<UiSelector> selector,
+Comparer::Comparer(const std::shared_ptr<UiDevice>& device, const std::shared_ptr<UiSelector>& selector,
                    const bool &earlyReturn)
     : mDevice(device), mSelector(selector), mEarlyReturn(earlyReturn)
 {
@@ -27,9 +27,9 @@ Comparer::Comparer(const std::shared_ptr<UiDevice> device, const std::shared_ptr
 
 Comparer::~Comparer() {}
 
-std::shared_ptr<AccessibleNode> Comparer::findObject(const std::shared_ptr<UiDevice> device,
-                                     const std::shared_ptr<UiSelector> selector,
-                                     const std::shared_ptr<AccessibleNode> root)
+std::shared_ptr<AccessibleNode> Comparer::findObject(const std::shared_ptr<UiDevice>& device,
+                                     const std::shared_ptr<UiSelector>& selector,
+                                     const std::shared_ptr<AccessibleNode>& root)
 {
     std::vector<std::shared_ptr<AccessibleNode>> ret = findObjects(device, selector, root, true);
     if (ret.size() > 0)
@@ -38,14 +38,13 @@ std::shared_ptr<AccessibleNode> Comparer::findObject(const std::shared_ptr<UiDev
         return nullptr;
 }
 
-std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::shared_ptr<UiDevice> device,
-                                                    const std::shared_ptr<UiSelector> selector,
-                                                    const std::shared_ptr<AccessibleNode> root, bool earlyReturn)
+std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::shared_ptr<UiDevice>& device,
+                                                    const std::shared_ptr<UiSelector>& selector,
+                                                    const std::shared_ptr<AccessibleNode>& root, bool earlyReturn)
 {
     Comparer comparer(device, selector, earlyReturn);
 
     LOGI("findObjects selector(%s) from (type:%s style:%s, role:%s, text:%s) earlyReturn:%d", selector->description().c_str(), root->getType().c_str(),  root->getStyle().c_str(),  root->getRole().c_str(),  root->getText().c_str(), earlyReturn);
-
     if (selector->mParent) {
         auto ret = Comparer::findObjects(device, selector->mParent, root);
         std::vector<std::shared_ptr<AccessibleNode>> merged{};
@@ -76,7 +75,7 @@ std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::sh
     return comparer.findObjects(root);
 }
 
-std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::shared_ptr<AccessibleNode> root)
+std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::shared_ptr<AccessibleNode>& root)
 {
     std::list<std::shared_ptr<PartialMatch>> partialList{};
     std::vector<std::shared_ptr<AccessibleNode>> ret = findObjects(root, 0, 1, partialList);
@@ -85,7 +84,7 @@ std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(const std::sh
 }
 
 std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(
-    const std::shared_ptr<AccessibleNode> root, const int &index, const int &depth,
+    const std::shared_ptr<AccessibleNode>& root, const int &index, const int &depth,
     std::list<std::shared_ptr<PartialMatch>> &partialMatches)
 {
     std::vector<std::shared_ptr<AccessibleNode>> ret;
@@ -108,7 +107,6 @@ std::vector<std::shared_ptr<AccessibleNode>> Comparer::findObjects(
             std::vector<std::shared_ptr<AccessibleNode>> childret =
                 findObjects(childNode, i, depth + 1, partialMatches);
             std::move(std::begin(childret), std::end(childret), std::back_inserter(ret));
-
             if (!ret.empty() && mEarlyReturn) {
                 LOGI("Object found and earlyReturn");
                 return ret;

diff --git a/org.tizen.aurum-bootstrap/inc/ObjectMapper.h b/org.tizen.aurum-bootstrap/inc/ObjectMapper.h
index 6bf7af7deb31beef3d022ea7a8d39af3c2c22629..d71ce6dcbdc3250e9b74d978f3c0180b6d4e8c2d 100644 (file)
--- a/org.tizen.aurum-bootstrap/inc/ObjectMapper.h
+++ b/org.tizen.aurum-bootstrap/inc/ObjectMapper.h
@@ -39,8 +39,8 @@ public:
 public:
     static ObjectMapper *getInstance();
     std::string addElement(std::shared_ptr<UiObject> object);
-    std::shared_ptr<UiObject> getElement(const std::string elementId);
-    bool removeElement(const std::string elementId);
+    std::shared_ptr<UiObject> getElement(const std::string& elementId);
+    bool removeElement(const std::string& elementId);
     void cleanUp();
 };
 

diff --git a/org.tizen.aurum-bootstrap/src/ObjectMapper.cc b/org.tizen.aurum-bootstrap/src/ObjectMapper.cc
index f3c7a157c03f56ee7aa6d7f54d7a7e4646ab3db4..87e1f01c158fdcb88be23142b1411404a80f3d97 100644 (file)
--- a/org.tizen.aurum-bootstrap/src/ObjectMapper.cc
+++ b/org.tizen.aurum-bootstrap/src/ObjectMapper.cc
@@ -33,13 +33,13 @@ ObjectMapper *ObjectMapper::getInstance()
 
 std::string ObjectMapper::addElement(std::shared_ptr<UiObject> object)
 {
-    std::string value = object->getId();
+    const std::string value = object->getId();
     mObjectMap[value] = object;
     LOGI("addElement %p, id %s", object.get(), value.c_str());
     return value;
 }
 
-std::shared_ptr<UiObject> ObjectMapper::getElement(std::string elementId)
+std::shared_ptr<UiObject> ObjectMapper::getElement(const std::string& elementId)
 {
     LOGI("getElement for elementId(%s)", elementId.c_str());
 
@@ -56,7 +56,7 @@ std::shared_ptr<UiObject> ObjectMapper::getElement(std::string elementId)
     }
 }
 
-bool ObjectMapper::removeElement(const std::string elementId)
+bool ObjectMapper::removeElement(const std::string& elementId)
 {
     LOGI("removeElement for Id(%s)", elementId.c_str());
     std::shared_ptr<UiObject> obj = getElement(elementId);