pinctrl: imx: fix allocation result check
authorRafał Miłecki <rafal@milecki.pl>
Wed, 22 Dec 2021 21:28:07 +0000 (22:28 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 26 Dec 2021 03:19:23 +0000 (04:19 +0100)
Fix code to check correct variable value.

Reported-by: Abel Vesa <abel.vesa@nxp.com>
Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20211222212807.27122-1-zajec5@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx.c

index 47b2ab1..16bc1bf 100644 (file)
@@ -667,7 +667,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
 
        group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
                                   sizeof(char *), GFP_KERNEL);
-       if (!func->group_names)
+       if (!group_names)
                return -ENOMEM;
        for_each_child_of_node(np, child)
                group_names[i] = child->name;