xwayland/window-manager: Avoid doing work for unknown window
authorRob Bradford <rob@linux.intel.com>
Thu, 10 Jan 2013 19:48:57 +0000 (19:48 +0000)
committerKristian Høgsberg <krh@bitplanet.net>
Thu, 10 Jan 2013 21:08:08 +0000 (16:08 -0500)
In particular if the hash table lookup fails and returns NULL then that value
would be passed into weston_wm_window_schedule_repaint which does not accept a
NULL value.

src/xwayland/window-manager.c

index 303ef15..b6e8e79 100644 (file)
@@ -800,8 +800,10 @@ weston_wm_handle_property_notify(struct weston_wm *wm, xcb_generic_event_t *even
        struct weston_wm_window *window;
 
        window = hash_table_lookup(wm->window_hash, property_notify->window);
-       if (window)
-               window->properties_dirty = 1;
+       if (!window)
+               return;
+
+       window->properties_dirty = 1;
 
        weston_log("XCB_PROPERTY_NOTIFY: window %d, ",
                property_notify->window);