habanalabs: add missing error check in sysfs clk_freq_mhz_show
authorTomer Tayar <ttayar@habana.ai>
Wed, 12 Jan 2022 09:20:41 +0000 (11:20 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 28 Feb 2022 12:22:03 +0000 (14:22 +0200)
Add a missing error check in the sysfs show functions for
clk_max_freq_mhz and clk_cur_freq_mhz_show.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/sysfs.c

index 3f220dd..c665a3a 100644 (file)
@@ -18,6 +18,8 @@ static ssize_t clk_max_freq_mhz_show(struct device *dev, struct device_attribute
                return -ENODEV;
 
        value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, false);
+       if (value < 0)
+               return value;
 
        hdev->asic_prop.max_freq_value = value;
 
@@ -59,6 +61,8 @@ static ssize_t clk_cur_freq_mhz_show(struct device *dev, struct device_attribute
                return -ENODEV;
 
        value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, true);
+       if (value < 0)
+               return value;
 
        return sprintf(buf, "%lu\n", (value / 1000 / 1000));
 }