drm/amd/display: revise Start/End SDP data
authorDavid Zhang <dingchen.zhang@amd.com>
Fri, 29 Apr 2022 21:38:14 +0000 (17:38 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 6 Jun 2022 18:40:57 +0000 (14:40 -0400)
[why & how]
We need to implement the VSC packet rev4 that is required by PSRSU.

Follow the eDP 1.5 spec pg. 257

changes in v2:
-------------------
- set vsc packet rev2 for PSR1

Cc: Chandan Vurdigerenataraj <chandan.vurdigerenataraj@amd.com>
Signed-off-by: David Zhang <dingchen.zhang@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c

index 79bc207415bcb0b0a259642a20429c923d374d4d..27ceba9d6d6581e0def0225644413b1223ac525e 100644 (file)
@@ -145,8 +145,10 @@ void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
                stereo3dSupport = true;
        }
 
-       /*VSC packet set to 2 when DP revision >= 1.2*/
-       if (stream->link->psr_settings.psr_version != DC_PSR_VERSION_UNSUPPORTED)
+       /* VSC packet set to 4 for PSR-SU, or 2 for PSR1 */
+       if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1)
+               vsc_packet_revision = vsc_packet_rev4;
+       else if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_1)
                vsc_packet_revision = vsc_packet_rev2;
 
        /* Update to revision 5 for extended colorimetry support */
@@ -159,6 +161,29 @@ void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
        if (vsc_packet_revision == vsc_packet_undefined)
                return;
 
+       if (vsc_packet_revision == vsc_packet_rev4) {
+               /* Secondary-data Packet ID = 0*/
+               info_packet->hb0 = 0x00;
+               /* 07h - Packet Type Value indicating Video
+                * Stream Configuration packet
+                */
+               info_packet->hb1 = 0x07;
+               /* 04h = VSC SDP supporting 3D stereo + PSR/PSR2 + Y-coordinate
+                * (applies to eDP v1.4 or higher).
+                */
+               info_packet->hb2 = 0x04;
+               /* 0Eh = VSC SDP supporting 3D stereo + PSR2
+                * (HB2 = 04h), with Y-coordinate of first scan
+                * line of the SU region
+                */
+               info_packet->hb3 = 0x0E;
+
+               for (i = 0; i < 28; i++)
+                       info_packet->sb[i] = 0;
+
+               info_packet->valid = true;
+       }
+
        if (vsc_packet_revision == vsc_packet_rev2) {
                /* Secondary-data Packet ID = 0*/
                info_packet->hb0 = 0x00;