validate:launcher: throw valgrind error only for definite loss

errors-for-leak-kinds should be set to definite, because almost every test case
, will have possibly lost memory, which may or may not be a leak.
And throwing error for all these cases doesn't seem to be correct.

https://bugzilla.gnome.org/show_bug.cgi?id=752754

diff --git a/validate/launcher/baseclasses.py b/validate/launcher/baseclasses.py
index b9b0aeb..0affd4d 100644 (file)
--- a/validate/launcher/baseclasses.py
+++ b/validate/launcher/baseclasses.py
@@ -316,6 +316,9 @@ class Test(Loggable):
             ('tool', 'memcheck'),
             ('leak-check', 'full'),
             ('leak-resolution', 'high'),
+            # TODO: errors-for-leak-kinds should be set to all instead of definite
+            #       and all false positives should be added to suppression files.
+            ('errors-for-leak-kinds', 'definite'),
             ('num-callers', '20'),
             ('log-file', '"' + vglogsfile + '"'),
             ('error-exitcode', str(VALGRIND_ERROR_CODE)),