drm/bridge: anx7625: use pm_runtime_force_suspend(resume)
authorHsin-Yi Wang <hsinyi@chromium.org>
Wed, 6 Jul 2022 12:52:52 +0000 (20:52 +0800)
committerRobert Foss <robert.foss@linaro.org>
Wed, 6 Jul 2022 13:19:50 +0000 (15:19 +0200)
There's no need to check for IRQ or disable it in suspend.

Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off
correctly. Make the system suspend/resume and pm runtime suspend/resume
more consistent.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Xin Ji <xji@analogixsemi.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220706125254.2474095-3-hsinyi@chromium.org
drivers/gpu/drm/bridge/analogix/anx7625.c

index ab346d3..fcf07a0 100644 (file)
@@ -2504,38 +2504,9 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev)
        return 0;
 }
 
-static int __maybe_unused anx7625_resume(struct device *dev)
-{
-       struct anx7625_data *ctx = dev_get_drvdata(dev);
-
-       if (!ctx->pdata.intp_irq)
-               return 0;
-
-       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
-               enable_irq(ctx->pdata.intp_irq);
-               anx7625_runtime_pm_resume(dev);
-       }
-
-       return 0;
-}
-
-static int __maybe_unused anx7625_suspend(struct device *dev)
-{
-       struct anx7625_data *ctx = dev_get_drvdata(dev);
-
-       if (!ctx->pdata.intp_irq)
-               return 0;
-
-       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
-               anx7625_runtime_pm_suspend(dev);
-               disable_irq(ctx->pdata.intp_irq);
-       }
-
-       return 0;
-}
-
 static const struct dev_pm_ops anx7625_pm_ops = {
-       SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume)
+       SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                               pm_runtime_force_resume)
        SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend,
                           anx7625_runtime_pm_resume, NULL)
 };