shared/gatt-client: Ignore orphaned characteristics

The gatt discovery proceedure simplification to discover all
characteristics at once has exposed a device side issue where some
device implementation reports orphaned characteristics.  While this
technically shouldn't be allowed, some instances of this were observed
(namely on some Android phones).

The fix is to simply skip over orphaned characteristics and continue
with everything else that is valid.

This has been tested as part of the Android CTS tests against an
affected platform and was confirmed to have worked around the issue.

Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>

diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index 58dd495..aeb9ade 100644 (file)
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -696,7 +696,13 @@ static bool discover_descs(struct discovery_op *op, bool *discovering)
                        util_debug(client->debug_callback, client->debug_data,
                                "Failed to insert characteristic at 0x%04x",
                                chrc_data->value_handle);
-                       goto failed;
+
+                       /* Some devices have been seen reporting orphaned
+                        * characteristics.  In order to favor interoperability
+                        * we skip over characteristics in error
+                        */
+                       free(chrc_data);
+                       continue;
                }
 
                if (gatt_db_attribute_get_handle(attr) !=