iris: call brw_process_intel_debug_variable() earlier
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Fri, 12 Nov 2021 23:16:38 +0000 (15:16 -0800)
committerMarge Bot <emma+marge@anholt.net>
Mon, 15 Nov 2021 23:33:18 +0000 (23:33 +0000)
We're currently only calling it after creating the screen and the
bufmgr. There are a few cases where Iris checks for the DEBUG_BUFMGR
bit before we call brw_process_intel_debug_variable(), which means
intel_debug is 0 and so we don't run the debug code. Today, these are
all related to the creation of the workaround bo and its mmap.

I found this in a custom branch after I converted to INTEL_DEBUG an
environment variable that I had.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13780>

src/gallium/drivers/iris/iris_screen.c

index 5e7e5dd..167875c 100644 (file)
@@ -802,6 +802,8 @@ iris_screen_create(int fd, const struct pipe_screen_config *config)
       break;
    }
 
+   brw_process_intel_debug_variable();
+
    screen->bufmgr = iris_bufmgr_get_for_fd(&screen->devinfo, fd, bo_reuse);
    if (!screen->bufmgr)
       return NULL;
@@ -820,8 +822,6 @@ iris_screen_create(int fd, const struct pipe_screen_config *config)
    if (!iris_init_identifier_bo(screen))
       return NULL;
 
-   brw_process_intel_debug_variable();
-
    screen->driconf.dual_color_blend_by_location =
       driQueryOptionb(config->options, "dual_color_blend_by_location");
    screen->driconf.disable_throttling =