net: dsa: felix: remove confusing/incorrect comment from felix_setup()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 12 Apr 2023 12:47:34 +0000 (15:47 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Apr 2023 04:56:06 +0000 (21:56 -0700)
That comment was written prior to knowing that what I was actually
seeing was a manifestation of the bug fixed in commit b4024c9e5c57
("felix: Fix initialization of ioremap resources").

There isn't any particular reason now why the hardware initialization is
done in felix_setup(), so just delete that comment to avoid spreading
misinformation.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/ocelot/felix.c

index 6dcebcf..80861ac 100644 (file)
@@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds,
        }
 }
 
-/* Hardware initialization done here so that we can allocate structures with
- * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing
- * us to allocate structures twice (leak memory) and map PCI memory twice
- * (which will not work).
- */
 static int felix_setup(struct dsa_switch *ds)
 {
        struct ocelot *ocelot = ds->priv;