orinoco: Annotate ezusb_docmd_wait()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Fri, 13 Nov 2020 21:22:51 +0000 (22:22 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 24 Nov 2020 15:01:18 +0000 (17:01 +0200)
All invocations of ezusb_docmd_wait() happen via ->cmd_wait(). This
callback is always invoked under the orinoco_lock() which disables BH.

Use ezusb_req_ctx_wait_poll() for ezusb_docmd_wait() because it must not
sleep.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201113212252.2243570-10-bigeasy@linutronix.de
drivers/net/wireless/intersil/orinoco/orinoco_usb.c

index c8508a3..4c60b48 100644 (file)
@@ -1082,7 +1082,7 @@ static int __ezusb_docmd_wait(struct hermes *hw, u16 cmd, u16 parm0,
 static int ezusb_docmd_wait(struct hermes *hw, u16 cmd, u16 parm0,
                            struct hermes_response *resp)
 {
-       return __ezusb_docmd_wait(hw, cmd, parm0, resp, ezusb_req_ctx_wait);
+       return __ezusb_docmd_wait(hw, cmd, parm0, resp, ezusb_req_ctx_wait_poll);
 }
 
 static int ezusb_bap_pread(struct hermes *hw, int bap,