Work around the compilation error of v8_value_converter.cc
authorCheng Zhao <zcbenz@gmail.com>
Thu, 26 Jan 2017 11:07:59 +0000 (20:07 +0900)
committerKevin Sawicki <kevinsawicki@gmail.com>
Mon, 6 Feb 2017 18:34:29 +0000 (10:34 -0800)
We should apply this patch in future:
https://chromium.googlesource.com/chromium/src/+/0232f57400b65505a27db30b1de5e918bf2481b1%5E%21/

atom/common/native_mate_converters/v8_value_converter.cc

index 046e6ef8f366427c2f916c710c8afca6e2c95e75..a064526557f9083faa0898e56c1707dee5bb4e90 100644 (file)
@@ -361,7 +361,7 @@ base::Value* V8ValueConverter::FromV8Array(
 
     base::Value* child = FromV8ValueImpl(state, child_v8, isolate);
     if (child)
-      result->Append(child);
+      result->Append(std::unique_ptr<base::Value>(child));
     else
       // JSON.stringify puts null in places where values don't serialize, for
       // example undefined and functions. Emulate that behavior.