staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Wed, 28 Sep 2016 18:19:32 +0000 (20:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Oct 2016 15:03:52 +0000 (17:03 +0200)
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_usb_rridresp_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x.h
drivers/staging/wlan-ng/hfa384x_usb.c

index 18588d6..0ba5517 100644 (file)
@@ -873,12 +873,12 @@ struct hfa384x_usb_statusresp {
        u16 resp2;
 } __packed;
 
-typedef struct hfa384x_usb_rridresp {
+struct hfa384x_usb_rridresp {
        u16 type;
        u16 frmlen;
        u16 rid;
        u8 data[HFA384x_RIDDATA_MAXLEN];
-} __packed hfa384x_usb_rridresp_t;
+} __packed;
 
 typedef struct hfa384x_usb_statusresp hfa384x_usb_wmemresp_t;
 
@@ -918,7 +918,7 @@ typedef union hfa384x_usbin {
        struct hfa384x_usb_infofrm infofrm;
        struct hfa384x_usb_statusresp cmdresp;
        struct hfa384x_usb_statusresp wridresp;
-       hfa384x_usb_rridresp_t rridresp;
+       struct hfa384x_usb_rridresp rridresp;
        hfa384x_usb_wmemresp_t wmemresp;
        hfa384x_usb_rmemresp_t rmemresp;
        hfa384x_usb_bufavail_t bufavail;
index 7d09f25..c21c591 100644 (file)
@@ -216,7 +216,7 @@ usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp,
                   hfa384x_cmdresult_t *result);
 
 static void
-usbctlx_get_rridresult(const hfa384x_usb_rridresp_t *rridresp,
+usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp,
                       hfa384x_rridresult_t *result);
 
 /*---------------------------------------------------*/
@@ -636,7 +636,7 @@ usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp,
 }
 
 static void
-usbctlx_get_rridresult(const hfa384x_usb_rridresp_t *rridresp,
+usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp,
                       hfa384x_rridresult_t *result)
 {
        result->rid = le16_to_cpu(rridresp->rid);
@@ -685,7 +685,7 @@ static inline struct usbctlx_completor *init_cmd_completor(
 struct usbctlx_rrid_completor {
        struct usbctlx_completor head;
 
-       const hfa384x_usb_rridresp_t *rridresp;
+       const struct hfa384x_usb_rridresp *rridresp;
        void *riddata;
        unsigned int riddatalen;
 };
@@ -713,7 +713,7 @@ static int usbctlx_rrid_completor_fn(struct usbctlx_completor *head)
 static inline struct usbctlx_completor *init_rrid_completor(
                                                struct usbctlx_rrid_completor
                                                        *completor,
-                                               const hfa384x_usb_rridresp_t
+                                               const struct hfa384x_usb_rridresp
                                                        *rridresp,
                                                void *riddata,
                                                unsigned int riddatalen)