Remove legacy resource value (PrivateBuild) in binaries. (#25560)
authorAaron Robinson <arobins@microsoft.com>
Thu, 4 Jul 2019 04:38:04 +0000 (21:38 -0700)
committerElinor Fung <47805090+elinor-fung@users.noreply.github.com>
Thu, 4 Jul 2019 04:38:04 +0000 (21:38 -0700)
* Remove legacy resource value (PrivateBuild) in binaries.

* Never set the private file flag on the binary

src/pal/prebuilt/inc/fxver.h
src/pal/prebuilt/inc/fxver.rc

index 7cb0cae..95ccbc6 100644 (file)
 
 #define EXPORT_TAG 
 
-#if OFFICIAL_BUILD
+// Not setting the private build flag until
+// official builds can be detected from native projects
+//#if OFFICIAL_BUILD
 #define VER_PRIVATE                 0
-#else
-#define VER_PRIVATE                 VS_FF_PRIVATEBUILD
-#endif
+//#else
+//#define VER_PRIVATE                 VS_FF_PRIVATEBUILD
+//#endif
 
 #define VER_SPECIALBUILD            0
 
 #define VER_COMMENTS_STR        "Flavor=" QUOTE_MACRO(URTBLDENV_FRIENDLY)
 #endif
 
-#define VER_PRIVATEBUILD_STR    QUOTE_MACRO(FX_VER_PRIVATEBUILD_STR)
-
 #if defined(__BUILDMACHINE__)
 #if defined(__BUILDDATE__)
 #define B2(x,y) " (" #x "." #y ")"
index a341041..ab037e7 100644 (file)
@@ -62,9 +62,6 @@ BEGIN
             VALUE "OleSelfRegister", "\0"
 #endif
             VALUE "Comments",        VER_COMMENTS_STR
-#if VER_PRIVATE
-            VALUE "PrivateBuild",    VER_PRIVATEBUILD_STR    
-#endif
 #ifdef VER_EXTRA_VALUES
             VER_EXTRA_VALUES
 #endif
@@ -87,9 +84,6 @@ BEGIN
             VALUE "OleSelfRegister", "\0"
 #endif
             VALUE "Comments",        VER_COMMENTS_STR
-#if VER_PRIVATE
-            VALUE "PrivateBuild",    VER_PRIVATEBUILD_STR    
-#endif
 #ifdef VER_EXTRA_VALUES
             VER_EXTRA_VALUES
 #endif