regulator: qcom-labibb: OCP interrupts are not a failure while disabled
authorMarijn Suijten <marijn.suijten@somainline.org>
Fri, 24 Dec 2021 11:34:50 +0000 (12:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:47 +0000 (11:03 +0100)
[ Upstream commit d27bb69dc83f00f86a830298c967052cded6e784 ]

Receiving the Over-Current Protection interrupt while the regulator is
disabled does not count as unhandled/failure (IRQ_NONE, or 0 as it were)
but a "fake event", usually due to inrush as the is regulator about to
be enabled.

Fixes: 390af53e0411 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Link: https://lore.kernel.org/r/20211224113450.107958-1-marijn.suijten@somainline.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/qcom-labibb-regulator.c

index b3da0dc..639b71e 100644 (file)
@@ -260,7 +260,7 @@ static irqreturn_t qcom_labibb_ocp_isr(int irq, void *chip)
 
        /* If the regulator is not enabled, this is a fake event */
        if (!ops->is_enabled(vreg->rdev))
-               return 0;
+               return IRQ_HANDLED;
 
        /* If we tried to recover for too many times it's not getting better */
        if (vreg->ocp_irq_count > LABIBB_MAX_OCP_COUNT)