efl_ui_widget: resolve warning about multiple defines
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Tue, 19 Mar 2019 20:28:10 +0000 (16:28 -0400)
committerYeongjong Lee <yj34.lee@samsung.com>
Tue, 2 Apr 2019 03:45:17 +0000 (12:45 +0900)
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8415

src/lib/elementary/efl_ui_widget.c

index a510018..a1883b0 100644 (file)
@@ -564,12 +564,7 @@ _logical_parent_eval(Eo *obj EINA_UNUSED, Elm_Widget_Smart_Data *pd, Eina_Bool s
           {
              if (efl_isa(pd->logical.parent, EFL_UI_WIDGET_CLASS))
                {
-                  ELM_WIDGET_DATA_GET(pd->logical.parent, logical_wd);
-                  if (!logical_wd)
-                    {
-                       ERR("Widget parent has the wrong type!");
-                       return NULL;
-                    }
+                  ELM_WIDGET_DATA_GET_OR_RETURN(pd->logical.parent, logical_wd, NULL);
                   logical_wd->logical.child_count --;
                }
              old = pd->logical.parent;
@@ -580,12 +575,7 @@ _logical_parent_eval(Eo *obj EINA_UNUSED, Elm_Widget_Smart_Data *pd, Eina_Bool s
           {
              if (efl_isa(parent, EFL_UI_WIDGET_CLASS))
                {
-                  ELM_WIDGET_DATA_GET(parent, parent_wd);
-                  if (!parent_wd)
-                    {
-                       ERR("Widget parent has the wrong type!");
-                       return NULL;
-                    }
+                  ELM_WIDGET_DATA_GET_OR_RETURN(parent, parent_wd, NULL);
                   parent_wd->logical.child_count ++;
                }
              pd->logical.parent = parent;