Fix logical error detected by static analysis tool 24/141524/1
authorJihoon Kim <jihoon48.kim@samsung.com>
Tue, 1 Aug 2017 02:46:28 +0000 (11:46 +0900)
committerJihoon Kim <jihoon48.kim@samsung.com>
Tue, 1 Aug 2017 02:46:34 +0000 (11:46 +0900)
Expression 'key < REMOTE_CONTROL_KEY_ENTER' is always false , which may be caused by a logical error

Change-Id: Ie499057a6281ddb68927c644cd0beb024196b385
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
ism/src/isf_remote_control.cpp

index be8c5df..bd70e85 100644 (file)
@@ -398,7 +398,7 @@ EXAPI int remote_control_input_resource_changed_callback_unset(remote_control_cl
 
 EXAPI int remote_control_send_key_event(remote_control_client *client, remote_control_key_type_e key)
 {
-    if (client == NULL || key < REMOTE_CONTROL_KEY_ENTER || key > REMOTE_CONTROL_KEY_CANCEL) {
+    if (client == NULL || key > REMOTE_CONTROL_KEY_CANCEL) {
         LOGE ("REMOTE_CONTROL_INVALID_PARAMETER");
         return REMOTE_CONTROL_INVALID_PARAMETER;
     }