multiqueue: do not reduce single queue below current level

When the single queue size was just bumped by 1 to allow more buffers to
be added, the buffers limit could be reduced to the current level when
setting the max-size-buffers property. This would result in a stall
since the queue would not grow anymore at this point.

Prevent this by not reducing a single queue size below the current
number of buffers + 1.

https://bugzilla.gnome.org/show_bug.cgi?id=712597

diff --git a/plugins/elements/gstmultiqueue.c b/plugins/elements/gstmultiqueue.c
index cc2f3fb..f7ed0ea 100644 (file)
--- a/plugins/elements/gstmultiqueue.c
+++ b/plugins/elements/gstmultiqueue.c
@@ -510,8 +510,8 @@ gst_multi_queue_set_property (GObject * object, guint prop_id,
         /* do not reduce max size below current level if the single queue has grown because of empty queue */
         if (new_size == 0) {
           q->max_size.visible = new_size;
-        } else {
-          q->max_size.visible = MAX (new_size, size.visible);
+        } else if (new_size > size.visible) {
+          q->max_size.visible = new_size;
         }
         tmp = g_list_next (tmp);
       };