Fix bugs found by static analysis.

Change-Id: I13168087ef460e74c203ab0f0311b91f6f2421f5

diff --git a/src/libdlogutil/logretrieve.c b/src/libdlogutil/logretrieve.c
index 58a5ca0..f9cca21 100644 (file)
--- a/src/libdlogutil/logretrieve.c
+++ b/src/libdlogutil/logretrieve.c
@@ -418,9 +418,9 @@ static int refill_fdi_buffers_special(dlogutil_state_s *state, int timeout)
        }
 
        // FIXME: can the sleep be interrupted via signals etc?
-       // also FIXME: can `needed_timeout` be -1 at this point?
+       if (needed_timeout > 0)
+               usleep(needed_timeout * USEC_PER_MSEC);
 
-       usleep(needed_timeout * USEC_PER_MSEC);
        for (int i = 0; i < state->fd_count; ++i) {
                if (!state->enabled[i])
                        continue;

diff --git a/src/logger/qos.c b/src/logger/qos.c
index b5b7f3b..0959120 100644 (file)
--- a/src/logger/qos.c
+++ b/src/logger/qos.c
@@ -56,6 +56,9 @@ void qos_create_limits_file(struct qos_module *qos, bool is_limiting)
 
        const int len = aggr_count * 32;
        __attribute__((cleanup(free_ptr))) char *buf = malloc(len);
+       if (!buf)
+               return;
+
        int pos = 0;
        for (int i = 0; i < aggr_count; ++i)
                if (aggr_infos[i].count >= 0) {