memoryleak: check return value correctly before clearing pointer
authorJukka Rissanen <jukka.rissanen@nokia.com>
Mon, 3 Jan 2011 09:55:22 +0000 (11:55 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 3 Jan 2011 19:38:41 +0000 (11:38 -0800)
src/service.c

index b90cc0c..18b0340 100644 (file)
@@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct connman_service *service)
        __connman_ipconfig_clear_address(service->ipconfig_ipv4);
        __connman_ipconfig_clear_address(service->ipconfig_ipv6);
 
-       if (__connman_ipconfig_disable(service->ipconfig_ipv4) < 0)
+       if (__connman_ipconfig_disable(service->ipconfig_ipv4) == 0)
                service->ipconfig_ipv4 = NULL;
 
-       if (__connman_ipconfig_disable(service->ipconfig_ipv6) < 0)
+       if (__connman_ipconfig_disable(service->ipconfig_ipv6) == 0)
                service->ipconfig_ipv6 = NULL;
 
        __connman_stats_service_unregister(service);