leds: core: Fix warning message when init_data
authorRicardo Ribalda Delgado <ribalda@kernel.org>
Wed, 1 Apr 2020 09:51:47 +0000 (11:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 08:36:37 +0000 (10:36 +0200)
[ Upstream commit 64ed6588c2ea618d3f9ca9d8b365ae4c19f76225 ]

The warning message when a led is renamed due to name collition can fail
to show proper original name if init_data is used. Eg:

[    9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision

Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/leds/led-class.c

index 647b126..d3e83c3 100644 (file)
@@ -281,7 +281,7 @@ int led_classdev_register_ext(struct device *parent,
 
        if (ret)
                dev_warn(parent, "Led %s renamed to %s due to name collision",
-                               led_cdev->name, dev_name(led_cdev->dev));
+                               proposed_name, dev_name(led_cdev->dev));
 
        if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
                ret = led_add_brightness_hw_changed(led_cdev);